__group__ ticket summary component version type owner status created _changetime _description _reporter 1.0 7 Some Utils are very experiment-centric Cleaning 1.0 enhancement somebody new 2016-10-25T13:07:35+01:00 2017-01-22T20:37:49Z "I noticed that a lot of Utils are not really general. For example, PlotUtils::SetMaskHist() is basically a Utility for MiniBooNE 2D CCQE measurements. I propose rationalising the Utils and moving anything which is experiment specific to the relevant folder. It'll make it easier to understand for users, particularly users who come from a single experiment. Perhaps the best thing is to have an ExpUtils namespace and put it in the same file which I'm proposing we move the experiment specific SignalDefs to." cwilkinson 2.0 79 Check NuWro -> NEUT mode converter Feature 2.0 defect lp208 new 2017-06-05T14:56:07+01:00 2017-06-05T14:56:07+01:00 lp208 2.0 78 Handle windows LE Code 2.0 defect somebody new 2017-06-02T10:29:29+01:00 2017-06-02T10:29:29+01:00 "Input config files with windows line endings should not cause the program to behave differently. Just strip off any extra '\r' characters when parsing lines." lp208 30 Write NUISCOMP Documentation Documentation defect somebody new 2016-11-01T11:38:20Z 2017-01-22T20:37:14Z Prepare proper documentation on how to run and analyse nuiscomp outputs. Patrick Stowell 31 Write NUISMIN documentation Documentation defect somebody new 2016-11-01T11:38:39Z 2017-01-22T20:37:14Z Write documentation on how to use minimiser Patrick Stowell 32 Write PrepareGENIE documentation Documentation defect somebody new 2016-11-01T11:39:02Z 2017-01-22T20:37:14Z Write documentation on how to handle GENIE inputs Patrick Stowell 37 MC Fine Error bands Feature defect somebody new 2016-11-04T11:29:08Z 2017-01-22T20:37:49Z MC Fine Error bands don't work. They seem to give large values ~100 instead of ~1E-38 meaning the error band plots are worthless. Patrick Stowell 43 fit_header not saving parameters Feature defect somebody new 2016-11-09T10:00:53Z 2017-01-22T20:37:49Z "Fit header not actually saving parameter values. Its also kind of awkward to read them out again from the ROOT file. Should add a python script to do this." Patrick Stowell 61 Card parser white space Code defect somebody new 2017-01-12T18:28:00Z 2017-01-22T20:37:49Z Card parser still cannot treat tabs as white space. Think it happens somewhere inside the JointFCN constructor. Patrick Stowell 63 NuWro Parameters sometimes cut off component1 defect somebody new 2017-01-12T18:30:00Z 2017-01-12T18:30:00Z NuWro sometimes seems to not read certain RW parameters when supplied in the cardfile. Rarely happens so could be an issue with certain enums conflicting? Patrick Stowell 67 Can't build without generators Code defect somebody new 2017-01-16T14:05:35Z 2017-01-22T20:37:49Z Latest versions have support for NUISANCE brand events, but you still require a generator to be enabled to build. One could just build against NUANCE as that has no dependencies, but it would be better if this was fixed in the cmake files. Patrick Stowell 69 NUISANCE accept BANFF output Feature defect somebody new 2017-01-19T17:42:22Z 2017-01-22T20:37:49Z "It'd be useful for T2K if NUISANCE could accept BANFF output as part of the data fit validations. We could compare to chosen inclusive and exclusive data sets with the best fit and report back to groups. This would mostly be easy (as many parameters are simple NEUT reweightings), but some parameters are normalisation only, based on mode. The BANFF have an input matrix specified by the NIWG to do this; we would just have to write a converter for each generator (e.g. 2p2h normalisation on Carbon). Cheers!" Clarence Wret 71 Checks in nuissys Feature defect somebody new 2017-02-05T20:00:09Z 2017-02-05T20:00:09Z "If by accident you pass a fit output file where you've fit parameters A and B, and forget to specify parameters A and B in the cardfile, there is no warning. Furthermore, if you only specify parameter A but the passed fit output file has parameter A and B the parameters are never varied. I think ERR(FTL) is suitable for the former, and for the latter we should probably be in support of varying only one parameter even though the fit output varied multiple parameters." Clarence Wret 81 splines segfault Cleaning defect somebody new 2017-08-09T19:52:30+01:00 2017-08-09T19:52:30+01:00 "Splines segfault on building splines routine. Should modify so instead of choosing Chunks the user choosers number of events to process at a time in case they pass a huge MC file in." Patrick Stowell 82 Utils are a mess Cleaning defect somebody new 2017-08-09T20:02:17+01:00 2017-08-09T20:02:17+01:00 "Utils functions are a mess, and its not clear what functions are in what Utils. StatUtils should be moved to its own folder, so that the statistical methods used by the sample classes are clear. FitUtils that are common for Events should be moved to FitEvent itself. e.g. A user should just be able to do FitEvent->Wrec(); GeneralUtils::ParseToStr should be moved into ParserUtils::ParseToStr. Remove fillneutmode array functions. Add a CovarUtils for handling of covariance matrices, inversion methods etc. " Patrick Stowell 83 Old set data functions Cleaning defect somebody new 2017-08-09T20:02:50+01:00 2017-08-09T20:02:50+01:00 Remove old deprecated inconsistent SetDataFromText functions Patrick Stowell 84 Remove Covariance Scaling Cleaning defect somebody new 2017-08-09T20:04:57+01:00 2017-08-09T20:04:57+01:00 Remove the horrible 1E-38 scaling applied to the covariances. Instead the average value should be calculated and stripped out. Patrick Stowell 85 Shape Covariance Cleaning defect somebody new 2017-08-09T20:08:50+01:00 2017-08-09T20:08:50+01:00 Need to add an option so that if someone uses SHAPE they can choose to use Teppei's shape matrix extraction algorithm to use only the SHAPE covariance too. Patrick Stowell 86 Error Bars From Con Cleaning defect somebody new 2017-08-09T20:09:19+01:00 2017-08-09T20:09:19+01:00 Error bars should be derived from the covariance if one is preset during the FinaliseMeasurement stage. Patrick Stowell 87 InputHandler->Write() Cleaning defect somebody new 2017-08-09T20:29:51+01:00 2017-08-09T20:29:51+01:00 "Input handlers should just have a Write function which saves the InputHandler as a Tree as a set of FitEvents to whatever the current gDirectory is. " Patrick Stowell 88 Bad ParticleMom in SaveEvents Cleaning defect somebody new 2017-08-09T20:52:48+01:00 2017-08-09T20:52:48+01:00 "Particle momentum is saved as ParticleMom = 3.367e-316, 3.15636e-316, 3.15649e-316, 3.36949e-316, 3.3695e-316, 3.36984e-316, 3.36984e-316, 3.36985e-316, 3.36985e-316, 3.36985e-316, 3.36986e-316, 3.36986e-316, 3.36987e-316, 3.36987e-316, 3.36988e-316, 3.36988e-316, 3.36989e-316, 3.36989e-316, 3.3699e-316, 3.3699e-316 in the FitEvent TTrees." Patrick Stowell 91 IterationTree Cleaning defect somebody new 2017-08-10T03:40:52+01:00 2017-08-10T03:40:52+01:00 Iteration tree is now not being saved for error bands throws. Patrick Stowell 92 MinimiserLog Cleaning defect somebody new 2017-08-10T03:41:42+01:00 2017-08-10T03:41:42+01:00 Should add an option so that the Minimiser saves its status to a log file as it goes along so that you can pick up from the parameters it was at if a job fails. Patrick Stowell 93 Signal in SampleSettings Cleaning defect somebody new 2017-08-10T03:42:21+01:00 2017-08-10T03:42:21+01:00 Add the number of signal that were found in SampleSettings Patrick Stowell 94 Split Covariance/Shape Covariance Cleaning defect somebody new 2017-08-10T03:44:08+01:00 2017-08-10T03:44:08+01:00 At the moment, SHAPE files are read in by checking for fIsShape and then adjusting the covariance path. Instead SampleSettings should contain both, and if SHAPE is called it tries to grab the alternative path. If it can't find the alternative path it uses Teppei's covariance extraction method to extract one. Patrick Stowell 95 SplashLogo Cleaning defect somebody new 2017-08-10T03:46:02+01:00 2017-08-10T03:46:02+01:00 Starting NUISANCE logo has been removed. Add this back in. Patrick Stowell 96 Setup.sh Cleaning defect somebody new 2017-08-10T15:43:31+01:00 2017-08-10T15:43:31+01:00 Setup.sh is build location dependent. We need the ability to just move the entire Linux build area and rerun it. Patrick Stowell 34 Error bands need a lot of throws component1 enhancement somebody new 2016-11-03T11:39:11Z 2017-01-22T20:37:49Z "I found that the error bands produced for even a single parameter are not very good for relatively small numbers of throws (100), for now this can be fixed by simply making more throws, although that is time intensive. In future, replacing the TProfile with a 1D hist for each bin, and fitting a Gaussian to the bin to get the error (for each y-axis bin) is probably better. For the histograms used for fitting, a limited range (maybe +/-3 * RMS) and a variable number of bins (maybe sqrt(entries) would be wise." cwilkinson 74 Pimpify the output canvas Feature enhancement somebody new 2017-02-08T15:17:31Z 2017-02-08T15:17:31Z The current output canvas does the job (shows data, MC, shape) but could do with some prettifying. E.g. add ratio plots, better plot names, different colors, and so on. Clarence Wret 76 Bubble chamber CC-inclusive Samples enhancement somebody new 2017-02-23T10:56:17Z 2017-02-23T10:56:17Z "There's plenty of CC inclusive data (and NC) for ANL and BNL and other BC. I (Clarence) have uploaded my total compiled documents to https://nuisance.hepforge.org/files/Bubble_Chamber_cwret.tar.gz" Clarence Wret 36 GENIE Target Info component1 defect somebody new 2016-11-03T12:47:17Z 2017-01-22T20:37:49Z Most of the Target Info is not currently needed in FitEvent. GENIE doesn't even fill this, but it would be nice to include it incase people want to separate out the hydrogen component at some point. Patrick Stowell 41 Reconfigure output looks worrying Cleaning defect somebody new 2016-11-09T09:24:34Z 2017-01-22T20:37:49Z "We should have a more sensible printout than this: {{{ [LOG Sample]: - 0/2500000 events ( 0%) [S,X,Y,Z,M,W] = [0, -999.90, -999.90, -999.90, 1, 1.00] [LOG Sample]: - 500000/2500000 events (20%) [S,X,Y,Z,M,W] = [0, -999.90, -999.90, -999.90, 1, 1.00] [LOG Sample]: - 1000000/2500000 events (40%) [S,X,Y,Z,M,W] = [1, 0.37, -999.90, -999.90, 12, 1.00] [LOG Sample]: - 1500000/2500000 events (60%) [S,X,Y,Z,M,W] = [0, -999.90, -999.90, -999.90, 1, 1.00] }}} " cwilkinson 53 Noisy GiBUU compilation Cleaning defect somebody new 2016-12-07T22:01:12Z 2017-01-22T20:37:49Z When you compile the GiBUU tools without a C++11 compiler, it does compile, but screams bloody murder at you. Can we get it to pipe down? cwilkinson 89 Weird output file issues Cleaning defect somebody new 2017-08-09T22:34:12+01:00 2017-08-09T22:34:12+01:00 For some reason, the output file for some MINERvA coherent samples gets oddly messed up. The data is there, and you can use it, but you can't view all of the histograms in a TBrowser. cwilkinson 90 Second flux histogram Cleaning defect somebody new 2017-08-09T22:36:48+01:00 2017-08-09T22:36:48+01:00 At some point, a second flux histogram started appearing, which is full of nonsense. We should rectify that. cwilkinson 12 EventManager SignalDef component1 enhancement somebody new 2016-10-25T13:23:27+01:00 2017-01-22T20:37:49Z The EventManager in JointFCN doesn't keep track of signal events, so its fast for nuiscomp but not for nuismin. It needs updating to track Signal + X,Y,Z, etc. Patrick Stowell 28 "Add generator ""how-to""" component1 enhancement somebody new 2016-11-01T10:31:57Z 2017-01-22T20:37:49Z "Need a generator how-to on the wiki. I (Clarence) have worked a bit on the NEUT one but it is far from complete." Clarence Wret 29 "Update ""experimental data"" on wiki" Documentation enhancement somebody new 2016-11-01T10:37:30Z 2017-01-22T20:37:49Z "Should try to have page with a few words on each experiment class. Also include fluxes for each measurement, possibly example card files/input settings for each generator No rush on this one, just logging it for the future" Clarence Wret 60 Remove FitWeight *rw from sample constructor component1 enhancement somebody new 2017-01-05T18:46:09Z 2017-01-22T20:37:49Z "The constructors for Measurement1D and Measurement2D derived objects (e.g. MINERvA_CC1pip_XSec_1Dpmu_nu) takes the FitWeight *rw object as an argument. This is no longer needed because MeasurementBase::SetupMeasurement does nothing with the weight engine. Hence it is unnecessary behaviour. Would require a large manual rescan of all the source code without any effect other than prettifying the code; do on a rainy day!" Clarence Wret 77 Error bands for validation Cleaning enhancement somebody new 2017-05-20T10:25:39+01:00 2017-05-20T10:25:39+01:00 Would be nice to get around to making the error bands for all datasets and put them somewhere. Semi-validation, semi-talk preparation cwilkinson 39 Add FNAL CC1pi- component1 task Clarence Wret assigned 2016-11-08T15:29:46Z 2017-01-22T20:37:49Z "On cvs there's FNAL CC1pi- measurement. Seems to have become lost in moving to git. Fix is relatively easy but measurement non-vital. Do on a rainy day" Clarence Wret 42 Add BNL multi-pi component1 task Clarence Wret assigned 2016-11-09T09:43:35Z 2017-01-22T20:37:49Z In the BNL 1986 1pi paper there are a few CC2pi, 3pi and even 4pi cross-sections. Could be fun to add. Clarence Wret 48 Method arguments should take (const) references where possible component1 task somebody new 2016-11-18T00:33:14Z 2017-01-22T20:37:49Z "There are a very large number of needless string copies throughout the codebase that would be gotten rid of by using updating functions and methods to take const string references where possible (almost everywhere). Probably similarly with any passed vectors/lists, they should be passed as references unless you really mean not to, const where possible." lp208 49 Lots of cloned THXs where the original pointer is lost component1 task somebody new 2016-11-18T06:37:14Z 2017-01-22T20:37:49Z Lots of times in the InputHandler (but i suspect elsewhere as well) a TH1D is cloned, edited and then the original pointer is set to the cloned one... the original histo is then non referencible. This is fine in pyROOT (assume they can refcount) as that histo should get swept up... but here we just end up with loads of cloned histos that are float-ie like... they probably get killed when the containing TFile kills them but might be worth cleaning them up for memories sake. lp208 80 GiBUU build needs to check gfortran version for compat Feature defect lp208 new 2017-07-20T16:46:04+01:00 2017-07-20T16:46:04+01:00 lp208 3 NUANCE Norm component1 task somebody new 2016-10-25T11:54:21+01:00 2017-01-22T20:37:49Z Need a good method to handle Nuance normalisation. Patrick Stowell